Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added transpilation step #223

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Added transpilation step #223

merged 3 commits into from
Oct 29, 2018

Conversation

sunesimonsen
Copy link
Member

This is the first step in the direction of modernizing the codebase.

@sunesimonsen sunesimonsen force-pushed the ssimonsen/transpilation branch from e1f6c3a to 15c95b1 Compare October 26, 2018 18:27
alexjeffburke
alexjeffburke approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@alexjeffburke alexjeffburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All for it - great to see a first step!

@sunesimonsen sunesimonsen mentioned this pull request Oct 26, 2018
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 840

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.537%
Totals Coverage Status
Change from base Build 835: 0.0%
Covered Lines: 529
Relevant Lines: 559
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 867

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.537%
Totals Coverage Status
Change from base Build 863: 0.0%
Covered Lines: 529
Relevant Lines: 559
💛 - Coveralls

papandreou
papandreou approved these changes Oct 27, 2018
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think transpilation is overkill for a plugin like this, but I'm not going to stand in the way of progress ;)

@sunesimonsen
Copy link
Member Author

I would like the plugin to keep working in older things like phantom that is why.

@sunesimonsen sunesimonsen force-pushed the ssimonsen/transpilation branch from 15c95b1 to 7c87241 Compare October 27, 2018 17:12
@sunesimonsen sunesimonsen force-pushed the ssimonsen/transpilation branch from 7c87241 to 3567237 Compare October 27, 2018 17:16
@sunesimonsen sunesimonsen merged commit 6eff8db into master Oct 29, 2018
@sunesimonsen sunesimonsen deleted the ssimonsen/transpilation branch October 29, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

@alexjeffburke alexjeffburke alexjeffburke approved these changes

@Munter Munter Awaiting requested review from Munter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunesimonsen @coveralls @papandreou @alexjeffburke