Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the codebase #224

Merged
merged 9 commits into from
Oct 29, 2018
Merged

Modernize the codebase #224

merged 9 commits into from
Oct 29, 2018

Conversation

sunesimonsen
Copy link
Member

@sunesimonsen sunesimonsen commented Oct 27, 2018

Fixes: #210

@coveralls
Copy link

coveralls commented Oct 27, 2018

Pull Request Test Coverage Report for Build 865

  • 201 of 210 (95.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 92.177%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/matchesSelector.js 1 4 25.0%
src/index.js 200 206 97.09%
Totals Coverage Status
Change from base Build 855: 0.6%
Covered Lines: 520
Relevant Lines: 547

💛 - Coveralls

@papandreou
Copy link
Member

Are you using lebab for the grunt work?

@papandreou
Copy link
Member

This has served me well recently:

for transform in arrow arrow-return let obj-shorthand obj-method ; do for dir in lib test; do lebab --transform $transform --replace $dir; done ; done

@sunesimonsen sunesimonsen force-pushed the ssimonsen/modernize branch 2 times, most recently from 4c51cc1 to 516f072 Compare October 27, 2018 18:51
@sunesimonsen
Copy link
Member Author

sunesimonsen commented Oct 27, 2018

Are you using lebab for the grunt work?

Yes :-)

@sunesimonsen
Copy link
Member Author

sunesimonsen commented Oct 27, 2018

@papandreou there was a good amount of magicpen usage that wasn't using the output argument, so that needed to be fixed manually.

It is a joy to refactor a codebase with this amount of tests.

@sunesimonsen sunesimonsen changed the title [WIP] Modernize the codebase Modernize the codebase Oct 27, 2018
@sunesimonsen
Copy link
Member Author

Most of this PR is automated rewriting, but I also have to do some manual work to get there. I count of the tests to validate the solution.

Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! There's also a few places where we can use template strings: #225

lebab --transform template --replace test
@sunesimonsen sunesimonsen changed the base branch from ssimonsen/transpilation to master October 29, 2018 07:39
@sunesimonsen sunesimonsen merged commit eacd8b4 into master Oct 29, 2018
@sunesimonsen sunesimonsen deleted the ssimonsen/modernize branch October 29, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants