-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize the codebase #224
Conversation
Pull Request Test Coverage Report for Build 865
💛 - Coveralls |
Are you using |
This has served me well recently:
|
4c51cc1
to
516f072
Compare
516f072
to
050e560
Compare
Yes :-) |
@papandreou there was a good amount of magicpen usage that wasn't using the output argument, so that needed to be fixed manually. It is a joy to refactor a codebase with this amount of tests. |
Most of this PR is automated rewriting, but I also have to do some manual work to get there. I count of the tests to validate the solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! There's also a few places where we can use template strings: #225
lebab --transform template --replace test
Fixes: #210