Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dashes in style names and values #241

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Allow dashes in style names and values #241

merged 1 commit into from
Nov 7, 2018

Conversation

sunesimonsen
Copy link
Member

@sunesimonsen sunesimonsen commented Nov 7, 2018 •
edited
Loading

Patch to the recently introduced style names validation.

papandreou
papandreou approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌

@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 933

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.177%
Totals Coverage Status
Change from base Build 929: 0.0%
Covered Lines: 520
Relevant Lines: 547
💛 - Coveralls

@sunesimonsen sunesimonsen merged commit c502a29 into master Nov 7, 2018
@sunesimonsen sunesimonsen deleted the ssimonsen/fix-dashes-in-styles branch November 7, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunesimonsen @coveralls @papandreou