Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsdom to version 15.0.0 #267

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 23, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ jsdom (^14.0.0 → ^15.0.0) · Repo · Changelog

Release Notes

15.0.0 (from changelog)

Several potentially-breaking changes, each of them fairly unlikely to actually break anything:

  • JSOM.fromFile() now treats .xht files as application/xhtml+xml, the same as it does for .xhtml and .xml. Previously, it would treat them as text/html.
  • If the JSDOM constructor's contentType option has a charset parameter, and the first argument to the constructor is a binary data type (e.g. Buffer or ArrayBuffer), then the charset will override any sniffed encoding in the same way as a Content-Type header would in browser scenarios. Previously, the charset parameter was ignored.
  • When using the Blob or File constructor with the endings: "native" option, jsdom will now convert line endings to \n on all operating systems, for consistency. Previously, on Windows, it would convert line endings to \r\n.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Apr 23, 2019
@coveralls
Copy link

coveralls commented Apr 23, 2019

Pull Request Test Coverage Report for Build 1114

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.405%

Totals Coverage Status
Change from base Build 1110: 0.0%
Covered Lines: 646
Relevant Lines: 675

💛 - Coveralls

@papandreou papandreou merged commit 573aa29 into master Apr 23, 2019
@depfu depfu bot deleted the depfu/update/npm/jsdom-15.0.0 branch April 23, 2019 08:13
alexjeffburke added a commit that referenced this pull request Jun 6, 2019
…dom-15.0.0"

This reverts commit 573aa29, reversing
changes made to 024cb73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants