Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snapshot testing for inspection and error checking #271

Merged
merged 4 commits into from
Jun 15, 2019

Conversation

sunesimonsen
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 14, 2019

Pull Request Test Coverage Report for Build 1150

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.463%

Totals Coverage Status
Change from base Build 1141: 0.0%
Covered Lines: 654
Relevant Lines: 683

💛 - Coveralls

@sunesimonsen sunesimonsen force-pushed the ssimonsen/snapshots branch from 4a0cc39 to 20be607 Compare June 15, 2019 06:48
@alexjeffburke
Copy link
Member

This looks pretty cool - I might be tempted to separate the use of template strings into a plain commit on master and then introduce the assertion changes separately.

Ultimately if the -snapshot plugin API is stable enough to be used and make other plugins dependent upon then lets try this.

@sunesimonsen
Copy link
Member Author

@alexjeffburke there is really no danger to this change. You can just search replace s/ snapshot// and switch to use https://github.com/gustavnikolaj/string-utils instead of expect.unindent.

@alexjeffburke
Copy link
Member

@sunesimonsen happy that we proceed! And to be fair we probably need some -snapshot mileage somewhere we know would benefit from it :)

Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🚀

@sunesimonsen sunesimonsen merged commit 32507e0 into master Jun 15, 2019
@sunesimonsen sunesimonsen deleted the ssimonsen/snapshots branch June 15, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants