First class support for test id's #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunesimonsen
force-pushed
the
ssimonsen/query-test-id
branch
from
4741404 to
3f3b66b
Compare
Pull Request Test Coverage Report for Build 1203
💛 - Coveralls |
This is more consistent with other assertions we have.
sunesimonsen
force-pushed
the
ssimonsen/query-test-id
branch
from
3f3b66b to
4adf6ab
Compare
sunesimonsen
force-pushed
the
ssimonsen/query-test-id
branch
from
4adf6ab to
4aee4a7
Compare
alexjeffburke
approved these changes
Sep 20, 2019
papandreou
approved these changes
Sep 20, 2019
| (expect, subject, testId) => { | ||
| expect.errorMode = 'nested'; | ||
| expect.subjectOutput = output => | ||
| expect.inspect(subject, Infinity, output); |
There was a problem hiding this comment.
Is this to avoid dotting out? Is it something we want in some of the other assertions as well?
There was a problem hiding this comment.
Yes, I have experience cases where we dot out stuff that contains conflicts. We should go through all of the assertions and make sure that we don't remove useful information, but that is a separate task: #287
|
Released as [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is becoming a recognised pattern for DOM testing to use test id's on elements.
Test id's is just a adding a
data-test-idattribute to elements so you have a stable way of finding them from your tests.We can already handle those, but it is kind of inconvenient and given how often it is used, I think we should add first class support for the concept.
Fixes: #285