Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for expect.it #297

Merged
merged 5 commits into from
Nov 18, 2019
Merged

Support for expect.it #297

merged 5 commits into from
Nov 18, 2019

Conversation

alexjeffburke
Copy link
Member

@alexjeffburke alexjeffburke commented Nov 18, 2019 •
edited
Loading

Add support for an expect.it() to level to "to satisfy" but disallow it at the top-level of "to contain".

@coveralls
Copy link

coveralls commented Nov 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1247

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.565%
Totals Coverage Status
Change from base Build 1241: 0.05%
Covered Lines: 688
Relevant Lines: 718
💛 - Coveralls

papandreou
papandreou approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@alexjeffburke alexjeffburke merged commit 1188810 into master Nov 18, 2019
@alexjeffburke alexjeffburke deleted the feature/expect-dot-it branch December 23, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

@sunesimonsen sunesimonsen Awaiting requested review from sunesimonsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexjeffburke @coveralls @papandreou