Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split assertion tests into their own files. #304

Merged
merged 18 commits into from
Dec 28, 2019
Merged

Split assertion tests into their own files. #304

merged 18 commits into from
Dec 28, 2019

Conversation

alexjeffburke
Copy link
Member

No description provided.

@alexjeffburke
Deduplicate the custom assertion for thrown error satisfying.
16d0d9f 
Run all the thrown errors through the "to throw an error satisfying"
rather than some using "to error" - none of the tests require the
semantics of the latter (catching promise resolution). This allows
removal of a little code.
@alexjeffburke
Prepare test configuration on node for per-assertion test files.
d089692
@alexjeffburke
Move "to have text" to a separate file.
86d327c
@alexjeffburke
Move "to have class" to a separate file.
5c0b603
@alexjeffburke
Move "to have attributes" to a separate file.
d8f5566
@alexjeffburke
Move "to have children" to a separate file.
e2423fd
@alexjeffburke
Move "to equal" to a separate file.
07ce7a0
@alexjeffburke
Move "to satisfy" to a separate file.
c69c638
@alexjeffburke
Move "to contain elements matching" to a separate file.
ffacaa1
@alexjeffburke
Move "to contain test id" to a separate file.
ebaf2fc
@alexjeffburke
Move "to match" to a separate file.
a2476c4
@alexjeffburke
Move "to have test id" to a separate file.
42636fc
@alexjeffburke
Move "to contain" to a separate file.
da19b4a
@alexjeffburke
Remove the use of when parsed from "to contain" tests.
d42a881 
This commit ensures these tests are isolated from dependencies on
other parts of the library.
@alexjeffburke
Bundle the tests for execution in karma.
a993f95
@alexjeffburke
Cleanup the top-level test file.
9ca017b
@alexjeffburke
Use IE11 compatible syntax for the common/browser custom assertion.
466d1c5
@alexjeffburke
Fix grabbing a body element in IE11 after 9ca017b.
67f144d
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1289

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 93.502%
Totals Coverage Status
Change from base Build 1285: -0.08%
Covered Lines: 690
Relevant Lines: 720
💛 - Coveralls

@sunesimonsen
Copy link
Member

Thank you so much for this effort 👌❤️🎉🤙

@alexjeffburke
Copy link
Member Author

@sunesimonsen @papandreou I did try to do this without a993f95, but I kept getting issues that looked like it getting confused about which test/snapshot were being compared. Added it as a means to move forward, and if we want to revisit we can do so separately.

papandreou
papandreou approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm obviously very interested to hear more about those snapshot problems? Sounds like something we really want to fix, not just to avoid that build step.

@alexjeffburke alexjeffburke merged commit 43a0ac5 into master Dec 28, 2019
@alexjeffburke alexjeffburke deleted the chore/separate-assertion-tests branch December 28, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

@sunesimonsen sunesimonsen Awaiting requested review from sunesimonsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexjeffburke @coveralls @sunesimonsen @papandreou