Update jsdom to ^22.1.0 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
force-pushed
the
chore/updateJsdom
branch
from
360f79d to
8786242
Compare
This was referenced Jul 20, 2023
Pull Request Test Coverage Report for Build 5607830833
💛 - Coveralls |
| @@ -64,7 +64,7 @@ | |||
| "fs-extra": "^9.0.0", | |||
| "gh-pages": "^4.0.0", | |||
| "istanbul": "^0.4.5", | |||
| "jsdom": "^15.2.0", | |||
| "jsdom": "^22.1.0", | |||
There was a problem hiding this comment.
Is it possible to require ^20.0.0 like Jest: https://github.com/jestjs/jest/blob/main/packages/jest-environment-jsdom/package.json#L27
There was a problem hiding this comment.
It's a dev dep, so there isn't much value in leaving the range open? At runtime you have to bring your own jsdom, and from what I can tell we do support the last many major versions. Would obviously be nice to test that this is the case, but that would require a different setup/build matrix I think.
There was a problem hiding this comment.
Oh great - let's just go ahead then.
sunesimonsen
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.