Don't require array-like subtypes to have the same constructor in order to be equal
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
force-pushed
the
tech/relaxArrayLikeEqual
branch
from
2404e9a to
037f5f6
Compare
papandreou
force-pushed
the
tech/relaxArrayLikeEqual
branch
from
037f5f6 to
3ff8d27
Compare
sunesimonsen
approved these changes
Jul 20, 2023
|
Released in 13.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
jsdominunexpected-domis causing trouble becauseNodeListinstances from different windows have different constructors in jsdom 16 and above.Seems like the easiest way to get unexpected and unexpected-dom to DTRT in that kind of scenario is to relax this requirement a bit and only require the objects to have the same
array-likesubtype.