Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add separate optchecks test to ci #5613

Merged
merged 5 commits into from
Apr 1, 2025
Merged

Conversation

aryairani
Copy link
Contributor

@aryairani aryairani commented Mar 6, 2025

add a limited, optimized compilation, to include OPT_CHECKs in CI

Second half of fix #5609

Alternative to #5615; We should merge whichever is faster? Once we have some more normal PRs merged into trunk, we can merge trunk into these to PRs and see the times.

@aryairani aryairani changed the title add optchecks test to ci add separate optchecks test to ci Mar 6, 2025
@aryairani aryairani marked this pull request as ready for review March 7, 2025 17:27
@aryairani aryairani requested a review from a team as a code owner March 7, 2025 17:27
@aryairani
Copy link
Contributor Author

This ended up appearing to be shorter to run than #5615; ~20 mins total vs ~27 mins.
Apparently the time saved by running transcripts with an optimized executable does not overcome the extra time it takes to produce the optimized executable. However it might make sense to switch strategies in the future if we are running more tests.

@aryairani aryairani merged commit 63c19d8 into trunk Apr 1, 2025
47 checks passed
@aryairani aryairani deleted the arya/runtime-optchecks-in-ci branch April 1, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-release build silently failing
2 participants