Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated to using zenity for the file selection dialog #6

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Migrated to using zenity for the file selection dialog #6

merged 3 commits into from
Oct 3, 2021

Conversation

The-Jonsey
Copy link
Member

Resolves #3

andydotxyz
andydotxyz reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth considering a fallback?
Not sure that zenity is a standard installed package.
Or maybe just needs to be in the install docs as a dependency?

@The-Jonsey The-Jonsey force-pushed the feature/zenity-file-opener branch from e9a3aef to ddc05bf Compare October 3, 2021 10:53
@The-Jonsey The-Jonsey merged commit ee28b28 into master Oct 3, 2021
The-Jonsey added a commit that referenced this pull request Dec 27, 2021
@The-Jonsey
Merge pull request #6 from unix-streamdeck/feature/zenity-file-opener
ad51a77 
Migrated to using zenity for the file selection dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the file dialogue box resizeable
3 participants
@The-Jonsey @andydotxyz @Louis-Jones-Evri