Skip to content

feat: animals -> heifer calf stages #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 7, 2025

Conversation

Minozzzi
Copy link
Collaborator

@Minozzzi Minozzzi commented Apr 4, 2025

No description provided.

@Minozzzi Minozzzi self-assigned this Apr 4, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 68 out of 68 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/app/modules/animals/data/use-cases/heifer-calf-stages-use-cases/remote-update-animal-heifer-calf-stage-use-case.ts:38

  • [nitpick] Consider aligning the error message terminology with the domain naming (e.g. 'animal heifer calf stage') for consistency and clarity.
throw new ForbiddenError(
        'Você não tem permissão para editar uma fase bezerra novilha'
      )

src/app/modules/animals/data/use-cases/heifer-calf-stages-use-cases/remote-get-animal-heifer-calf-stages-use-case.ts:45

  • [nitpick] Verify that the property 'item.weighing' accurately reflects the intended domain model field 'weight'. If possible, consider using consistent naming between the API response and the domain model.
weight: item.weighing,

@Minozzzi Minozzzi requested a review from Copilot April 4, 2025 20:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 69 out of 69 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/app/modules/animals/data/use-cases/heifer-calf-stages-use-cases/remote-update-animal-heifer-calf-stage-use-case.ts:39

  • [nitpick] The error message refers to 'fase bezerra novilha' while the use case names and file paths consistently use 'animal heifer-calf stage'. Consider aligning the terminology for consistency.
throw new ForbiddenError('Você não tem permissão para editar uma fase bezerra novilha')

@Minozzzi Minozzzi merged commit 6e41713 into develop Apr 7, 2025
1 check passed
@Minozzzi Minozzzi deleted the feat/animals/heifer-calf-stages branch April 8, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant