Remove duplidated day in bootstrap-datepicker.kh.js #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
File name should be .km rather than .kh as in https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/km.yml |
|
Thanks for the PR, can you add a new translation file with the correct language code and add a deprecation message in the incorrect language code file? See bootstrap-datepicker.kr.js for an example |
|
Thank you very much for your quick response. Yes, I have added deprecated message in the .kh, and create a new bootstrap-datepicker.km.js. Please kindly review it :) |
|
@acrobat My apology for annoying, but just a following up if there is anything else you need in order to for this PR to be merged? |
|
Nope, just lost track of the PR. Thanks @somethvictory! |
|
Thank you very much :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.