-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files option for npm, fix indents on tests #1883
Conversation
@@ -59,7 +59,6 @@ module.exports = function(grunt){ | |||
}, | |||
concat: { | |||
options: { | |||
banner: '<%= banner %>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For unification banner for js and css files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes I see, it's now in the usebanner task!
Thanks @vsn4ik for the cleanup! Can you restore these files:
Also please take a look at the travis build! Thanks! |
@acrobat I'm not going to restore unwanted files and unused libraries. |
Ok, I will add the new jquery file in a separate PR for extra tests. I see you did a lot of small changes to the main js file, the changes look good on first sight. Can you guys also take a look @hebbet @Azaret, thanks! |
@vsn4ik thanks for fixing the comments! Is it maybe possible to move the changes to |
Done. |
Thanks @vsn4ik! Will review the other PR soon! |
.npmignore
to.gitignore
files
option onpackage.json