Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trigger change or changeDate on initialization #1912

Merged
merged 1 commit into from
Jun 13, 2016
Merged

Do not trigger change or changeDate on initialization #1912

merged 1 commit into from
Jun 13, 2016

Conversation

teoulas
Copy link
Contributor

@teoulas teoulas commented Jun 7, 2016 •
edited
Loading

Fixes #1561
Fixes #1512
Fixes #1846
... and probably more, please add them if you can.

Also includes relevant test.

@teoulas teoulas force-pushed the fix-init-events branch from 3706ada to 0a632af Compare June 7, 2016 10:32
@acrobat
Copy link
Member

acrobat commented Jun 7, 2016 •
edited
Loading

@hebbet, @vsn4ik @Azaret whyat do you guys think? Looks good to me and does indeed fix a good amount of tickets

@teoulas teoulas force-pushed the fix-init-events branch from 0a632af to cd11c97 Compare June 7, 2016 13:25
@vsn4ik
Copy link
Member

vsn4ik commented Jun 7, 2016

LGTM!

@teoulas
Copy link
Contributor Author

teoulas commented Jun 13, 2016

Hey guys,

I've just rebased and fixed the conflicts. I would appreciate if we merged this soon.

@acrobat acrobat added this to the 1.7.0 milestone Jun 13, 2016
@acrobat acrobat merged commit 80429da into uxsolutions:master Jun 13, 2016
@acrobat
Copy link
Member

acrobat commented Jun 13, 2016

Thanks @teoulas

@teoulas
Copy link
Contributor Author

teoulas commented Jun 13, 2016

Awesome, thanks! 👍

@teoulas teoulas deleted the fix-init-events branch June 13, 2016 09:53
@fridde fridde mentioned this pull request Feb 10, 2017
Closed
@acrobat acrobat mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@teoulas @acrobat @vsn4ik @lightfoot256 @Owheee