Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data-date-dates-disabled attribute to accept a comma-separated list #1946

Merged
merged 2 commits into from
Jul 15, 2016

Conversation

maxfurman
Copy link
Contributor

Setting multiple datesDisabled through a data attribute is currently broken, because the _process_options function assumes that if that value is not already an array it is only one datestring. This is not always the case; if you try to pass multiple dates to the data-date-dates-disabled attribute they will be interpreted as one long string and fail to parse as dates. Fixed by calling .split(',') on the raw value. Strings without commas will simply be wrapped in an array, which is the current behavior.

@acrobat
Copy link
Member

acrobat commented Jul 15, 2016

Thanks @maxfurman

@acrobat acrobat merged commit 3bde2d8 into uxsolutions:master Jul 15, 2016
@acrobat acrobat mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants