Remove listen changeDate after destroy DateRangePicker

[lusever]

Need for correct recreate DateRangePicker on same inputs.

[vsn4ik]

this.dateUpdated !== $.proxy(this.dateUpdated, this);

[lusever]

Yes. But it is work for jQuery. From docs:

When jQuery attaches an event handler, it assigns a unique id to the handler function. Handlers proxied by jQuery.proxy() or a similar mechanism will all have the same unique id (the proxy function), so passing proxied handlers to .off may remove more handlers than intended. In those situations it is better to attach and remove event handlers using namespaces.

[lusever]

И чего?

[vsn4ik]

https://github.com/eternicode/bootstrap-datepicker/blob/master/js/bootstrap-datepicker.js#L2001 используется нэймспейс. Я считаю что лучше использовать нэймспейс, даже jQuery советует.

[lusever]

I changed the way of removing events to namespace.

[vsn4ik]

You need to add namespace here (https://github.com/eternicode/bootstrap-datepicker/blob/master/js/bootstrap-datepicker.js#L1513) and add testcase.

[lusever]

I added namespace.
@vsn4ik prompt me please place where to create the testcase correctly.

[acrobat]

@vsn4ik I think we can't add a namespace now, this would mean a BC break. We can only change the namespace in 2.0 (We can also fix issue like this only when we develop 2.0 #337). Why is the namespace necessary?

[vsn4ik]

@acrobat Let's roll out without tests. Namespace is not necessary.

[acrobat]

@lusever Can you remove the .datepicker namespace on both events? If that still fixes your issue the pr is good to go!

[lusever]

@acrobat I removed namespaces.

[lusever]

If I use the code which is currently:

$('.inputs input').on('changeDate', myFunc)
$('.inputs').datepicker({inputs: $('input')})
$('.inputs').data('datepicker').remove(); // removed myFunc too

I think the original version is more correct. It is like in _unapplyEvents.
I think it is necessary to restore the original version. Then myFunc will not be removed.

[acrobat]

So the changes in this PR are not correct @lusever?

[lusever]

@acrobat now is correct.

[acrobat]

Thanks @lusever!