Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed reference to stefan petre's #2031

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Oct 2, 2016

Our codebase has diverged a lot from the original code. So further references aren't necessary. Discussed with @eternicode

From 1.7.0+ there won't be any references anymore

@acrobat acrobat added the meta label Oct 2, 2016
@acrobat acrobat added this to the 1.7.0 milestone Oct 2, 2016
@acrobat acrobat merged commit b65fe6a into uxsolutions:master Oct 7, 2016
@acrobat acrobat deleted the reference-cleanup branch October 7, 2016 17:04
@Azaret
Copy link
Contributor

Azaret commented Oct 12, 2016

RIP 🍕
I'm not much sure about this.
First, while our code did evolved in 3 years, jQuery call, methods, events and options and event the plugin name are still the same.
Then, it offers visibility on Google, since eyecon.ro is still up. If someone if looking up for eyecon or stefan petre, maybe because they didn't updated the plugin since few years, our fork is referenced next to stefan's in Google.

At the end I don't care much to be honest, just that I guess keeping it have a bit of benefice and no harm I guess.

@Azaret
Copy link
Contributor

Azaret commented Oct 12, 2016

I would let some notice in the readme and the JS header.
Tho I agree on cleaning the rest ;)

@Azaret
Copy link
Contributor

Azaret commented Oct 12, 2016

Also this PR contains non related commit, this is evil @acrobat 😈 😄

@acrobat
Copy link
Member Author

acrobat commented Oct 12, 2016

@Azaret If you want you can open a new PR with some additions to the readme and jq header! Would not harm for visibility indeed!

@acrobat acrobat mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants