Add notes about multiple dates and examples for update method #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Azaret
commented
Nov 10, 2016
Azaret
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #2038 |
acrobat
reviewed
Nov 11, 2016
| If ``date`` is provided and is a Date object, it is assumed to be a "local" date object, and will be converted to UTC for internal use. | ||
| Update the datepicker with given arguments or the current input value. | ||
| The arguments can be either an array of strings, an array of Date objects, multiples strings or multiples Date objects. | ||
| If ``date`` arguments are provided and are Date objects, it is assumed to be "local" Date objects, and will be converted to UTC for internal use. |
|
Just one little comment, extra info looks good! |
acrobat
approved these changes
Nov 11, 2016
|
Thanks @Azaret |
|
Thank to you @acrobat 😉 |
vsn4ik
reviewed
Nov 11, 2016
| @@ -39,17 +39,21 @@ update | |||
|
|
|||
| Arguments: | |||
|
|
|||
| * date (String|Date|Array, optional) | |||
| * date (String|Date, optional) | |||
There was a problem hiding this comment.
@Azaret I think that you want to delete this line and leave * date (String|Date|Array, optional).
There was a problem hiding this comment.
Well I wasn't sure how to show the fact that date is *args for string and Date. But not when Array.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.