-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tamil Language support #2119
Tamil Language support #2119
Conversation
.gitignore
Outdated
@@ -4,6 +4,7 @@ docs/_build | |||
# OS or Editor folders | |||
.DS_Store | |||
.idea | |||
*.iml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Will do.
Hi @abuabdul, Thanks for the translation only one comment left to fix! |
@acrobat I have fixed it. |
Thanks @abuabdul |
I believe that at the moment we enforce usage of ISO 639-1 unless we want to add a variant or a language for a specific country.
Then we should rename the file and internal name to |
Well I would have a word from @abuabdul on this 😄 |
Yeah I was a bit quick with the changes. I'm going to revert my commit for now and wait for the feedback from @abuabdul. If the locale key needs to change we can do it in a 1.7.x release! |
Hi, I guess @Azaret is right. The translation will be mostly same if other dialects like Malaysian Tamil or Colombo Tamil did translate. The dialects of Tamil could be different regionally but the calendar translation is same since it is a Gregorian. So i will agree to rename. Thanks @Azaret. @acrobat let me know if you want me to rename the file. |
@abuabdul Yeah if you also agree that the locale code should be 'TA' then please create a PR to rename the file and locale code in the file. Thanks! |
Fix Tamil Language file with proper locale code, see #2119
Demo:
http://b2oplus.org/bootstrap-datepicker/