Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm on README.md #2160

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Add npm on README.md #2160

merged 1 commit into from
Apr 3, 2017

Conversation

vsn4ik
Copy link
Member

@vsn4ik vsn4ik commented Apr 2, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no

acrobat
acrobat requested changes Apr 2, 2017
View reviewed changes
Copy link
Member

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, otherwise good to go!

README.md Outdated
@@ -21,7 +23,18 @@ Please note: It might take a few hours until a new version is available on cdnjs

## Development

Once you cloned the repo, you'll need to install [grunt](http://gruntjs.com/) and the development dependencies using [yarn](https://yarnpkg.com/).
Once you cloned the repo, you'll need to install [grunt](https://gruntjs.com/) and the development dependencies using package manager:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

....using a package manager...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated

$ [sudo] yarn global add grunt-cli
$ yarn install
* [yarn](https://yarnpkg.com/):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add (Recommended) at the end of this line. As we want to encourage people to use yarn. As it is faster, safer to use

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

acrobat
acrobat approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acrobat
Copy link
Member

acrobat commented Apr 3, 2017

Thanks @vsn4ik!

@acrobat acrobat merged commit 9d74dea into uxsolutions:master Apr 3, 2017
@vsn4ik vsn4ik deleted the add-npm-install branch April 3, 2017 12:08
@acrobat acrobat mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsn4ik @acrobat