Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification opened-changed event spam while using modal dialog #21085

Closed
knoobie opened this issue Feb 27, 2025 · 6 comments · Fixed by #21119
Closed

Notification opened-changed event spam while using modal dialog #21085

knoobie opened this issue Feb 27, 2025 · 6 comments · Fixed by #21119

Comments

@knoobie
Copy link
Contributor

knoobie commented Feb 27, 2025

Description of the bug

When I have a notification and a modal dialog my log is bombarded with log messages.. making me wonder.. is my application broken?

Log from a single button click.

2025-02-27T11:45:48.985+01:00  INFO 43060 --- [] [nio-8080-exec-6] c.v.f.i.nodefeature.ElementListenerMap   : Ignored listener invocation for opened-changed event from the client side for an inert vaadin-notification element
2025-02-27T11:45:48.985+01:00  INFO 43060 --- [] [nio-8080-exec-6] c.v.f.i.nodefeature.ElementListenerMap   : Ignored listener invocation for opened-changed event from the client side for an inert vaadin-notification element
2025-02-27T11:45:53.976+01:00  INFO 43060 --- [] [nio-8080-exec-4] c.v.f.s.c.r.AbstractRpcInvocationHandler : Ignored RPC for invocation handler 'com.vaadin.flow.server.communication.rpc.MapSyncRpcHandler' from the client side for an inert node id='604'
2025-02-27T11:45:53.976+01:00  INFO 43060 --- [] [nio-8080-exec-4] c.v.f.i.nodefeature.ElementListenerMap   : Ignored listener invocation for opened-changed event from the client side for an inert vaadin-notification element
2025-02-27T11:45:53.976+01:00  INFO 43060 --- [] [nio-8080-exec-4] c.v.f.i.nodefeature.ElementListenerMap   : Ignored listener invocation for opened-changed event from the client side for an inert vaadin-notification element

Expected behavior

No log message is provided. Notification works even with a modal dialog - automatical exclusion for server side modal feature?

Minimal reproducible example

    var btn = new Button("Click Me", e -> {
      Notification.show("Hi. I'm a notification.");

      var dialog = new Dialog();
      dialog.setModal(true);
      dialog.add(new Paragraph("Lorem Ipsum. Let this stay open until Notification disappears."));
      dialog.open();
    });

Versions

  • Vaadin / Flow version: latest
  • Java version: latest
@mshabarov mshabarov transferred this issue from vaadin/flow Mar 4, 2025
@caalador
Copy link
Contributor

caalador commented Mar 4, 2025

This might need some change in Flow so that we could also use @AllowInert with @Synchronize

@knoobie
Copy link
Contributor Author

knoobie commented Mar 4, 2025

I think I said that something else as well: Synchronize needs an attribute allowInert which is set to true for all Vaadin internal communications to synchronize server and client - this problem is also within the Sidebar and its pretty annoying.

@yuriy-fix yuriy-fix added the bug label Mar 5, 2025
@yuriy-fix
Copy link
Contributor

Based on @caalador comment transferring it to the flow repository. We can evaluate if changes are needed on our side once it's addressed.

@yuriy-fix yuriy-fix removed the bug label Mar 5, 2025
@yuriy-fix yuriy-fix transferred this issue from vaadin/flow-components Mar 5, 2025
@mshabarov mshabarov moved this from 🆕 Needs triage to 🔖 Normal Priority (P2) in Vaadin Flow bugs & maintenance (Vaadin 10+) Mar 11, 2025
@mcollovati mcollovati added the BFP Bugfix priority, also known as Warranty label Mar 11, 2025
@mcollovati
Copy link
Collaborator

The issue was triaged and currently added to the backlog priority queue for further investigation

@mcollovati mcollovati moved this from 🔖 Normal Priority (P2) to 🔖 High Priority (P1) in Vaadin Flow bugs & maintenance (Vaadin 10+) Mar 11, 2025
@mshabarov mshabarov moved this to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Mar 12, 2025
@mshabarov mshabarov moved this from 🪵Product backlog to 🟢Ready to Go in Vaadin Flow ongoing work (Vaadin 10+) Mar 12, 2025
@tepi tepi self-assigned this Mar 12, 2025
@tepi tepi moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Mar 12, 2025
@tepi tepi moved this from ⚒️ In progress to 🔎Iteration reviews in Vaadin Flow ongoing work (Vaadin 10+) Mar 13, 2025
@github-project-automation github-project-automation bot moved this from 🔎Iteration reviews to Done in Vaadin Flow ongoing work (Vaadin 10+) Mar 17, 2025
@github-project-automation github-project-automation bot moved this from 🔖 High Priority (P1) to ✅ Closed in Vaadin Flow bugs & maintenance (Vaadin 10+) Mar 17, 2025
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.14.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

7 participants