fix: set page height to 100% instead of 100vh #21025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Mar 13, 2025
mshabarov
approved these changes
Mar 13, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
The PR modifies the page height from 100vh to 100% to prevent the content area from extending underneath the navbar on mobile devices:
- body, #outlet {
+ html, body, #outlet {
- height: 100vh;
+ height: 100%;
width: 100%;
margin: 0;
}
vaadin-bot
added a commit
that referenced
this pull request
Mar 14, 2025
The PR modifies the page height from 100vh to 100% to prevent the content area from extending underneath the navbar on mobile devices:
- body, #outlet {
+ html, body, #outlet {
- height: 100vh;
+ height: 100%;
width: 100%;
margin: 0;
}
Co-authored-by: Sergey Vinogradov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.8.0.alpha2 and is also targeting the upcoming stable 24.8.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR modifies the page height from
100vhto100%to prevent the content area from extending underneath the navbar on mobile devices:Fixes #21024
Type of change