fix: remove responsive step styles when switching to auto-responsive #8860
+113
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
changed the title
web-padawan
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that styles applied by responsive steps mode are properly removed when switching to auto-responsive mode in order to avoid unintended side effects. This is specifically important in React wrappers. They use
@lit/reactwhich applies web component properties and attributes after the component has already connected to the DOM. As a result, there is a short window during which responsive steps styles can be applied.An alternative solution could be to delay the initialization of responsive steps styles, but this causes some tests to fail, so I think it's safer to leave it as is for now even though it may be less optimal from the performance perspective.
Related to vaadin/platform#7172