Status deprecated update2 #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: - Links - Text - Various miscellaneous fixes
Done the rest of the fixes - Added references - Fixed links - Fixed badly copied text
jimstir
reviewed
Mar 7, 2025
|
|
||
| On top of this RLPx-based subprotocols are ran, the client | ||
| SHOULD NOT use [Whisper V6](https://eips.ethereum.org/EIPS/eip-627), the client | ||
| SHOULD use [Waku V1](https://rfc.vac.dev/waku/standards/legacy/6/waku1) |
There was a problem hiding this comment.
Should be a relative link to this repo. e.g (waku/standards/legacy/6/waku1.md)
| Once a Whisper and/or Waku node is up and running there are some specific settings required | ||
| to communicate with other Status nodes. | ||
|
|
||
| See [3/WHISPER-USAGE](https://rfc.vac.dev/status/deprecated/whisper-usage) and [10/WAKU-USAGE](https://rfc.vac.dev/status/deprecated/waku-usage) for more details. |
There was a problem hiding this comment.
Remove numbers + make links relative.
|
|
||
| ### Data Sync | ||
|
|
||
| [MVDS](https://specs.vac.dev/mvds.html) is used for 1:1 and group chats, however it is currently not in use for public chats. |
There was a problem hiding this comment.
This link does not work, update it. e.g 2/MVDS
Comment on lines
+236
to
+243
| - [EstimateGas Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L499) | ||
| - [PendingNonceAt Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L440) | ||
| - [SuggestGasPrice Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L487) | ||
| - [SendTransaction Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L512) | ||
| - [BlockByHash Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L78) | ||
| - [BlockByNumber Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L82) | ||
| - [FilterLogs Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L377) | ||
| - [NonceAt Implementation](https://github.com/ethereum/go-ethereum/blob/26d271dfbba1367326dec38068f9df828d462c61/ethclient/ethclient.go#L366) |
There was a problem hiding this comment.
For links that are the same and are mentioned multiple times in the spec should be placed in the reference section once.
| the access token SHOULD be included in the advertisement. | ||
| Otherwise it SHOULD be left empty. | ||
|
|
||
| This SHOULD be advertised on the [contact code topic](./10-waku-usage.md#contact-code-topic) |
| MUST be sent to the server on the topic derived from the hashed public key of the | ||
| key we are querying, as [described above](#query-topic). | ||
|
|
||
| An ephemeral key SHOULD be used and SHOULD NOT be encrypted using the [secure transport](../docs/stable/5-secure-transport.md). |
|
|
||
| | Uncompressed | Compressed | | ||
| | --- | --- | | ||
| |<img src="https://user-images.githubusercontent.com/5702426/80531063-e98fcc80-8991-11ea-8c02-c354b5828d35.png" alt=QR width="400" />|<img src="https://user-images.githubusercontent.com/5702426/80501933-f4356c00-8967-11ea-87d8-eae18becece9.png" alt=QR width="400"/>| |
There was a problem hiding this comment.
Download the image and place the image within the directory: status/deprecated/images. An example here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are from the previous PR: #109