Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timing issue in the new tot-net-out replica test #1060

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix timing issue in the new tot-net-out replica test #1060

merged 1 commit into from
Sep 20, 2024

Conversation

enjoy-binbin
Copy link
Member

Apparently there is a timing issue when using wait_for_ofs_sync:

[exception]: Executing test client: can't read "out_before": no such variable.
can't read "out_before": no such variable

The reason is that if the connection between the primary
and the replica is not established yet, the master_repl_offset
of the primary and replica in wait_for_ofs_sync is 0, and
the check fails, resulting in no replica client in the
client list below.

In this case, we need to make sure the replica is online
before proceeding.

@enjoy-binbin
Fix timing issue in the new tot-net-out replica test
056b85b 
Apparently there is a timing issue when using wait_for_ofs_sync:
```
[exception]: Executing test client: can't read "out_before": no such variable.
can't read "out_before": no such variable
```

The reason is that if the connection between the primary
and the replica is not established yet, the master_repl_offset
of the primary and replica in wait_for_ofs_sync is 0, and
the check fails, resulting in no replica client in the
client list below.

In this case, we need to make sure the replica is online
before proceeding.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin
Copy link
Member Author

the failed ci link: https://github.com/valkey-io/valkey/actions/runs/10950803684/job/30406733305#step:6:723

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.58%. Comparing base (56fd977) to head (056b85b).
Report is 15 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #1060      +/-   ##
============================================
+ Coverage     70.47%   70.58%   +0.10%     
============================================
  Files           114      114              
  Lines         61672    61672              
============================================
+ Hits          43466    43531      +65     
+ Misses        18206    18141      -65

see 13 files with indirect coverage changes

@enjoy-binbin enjoy-binbin merged commit d9c41e9 into valkey-io:unstable Sep 20, 2024
46 checks passed
@enjoy-binbin enjoy-binbin deleted the fix_timing_issue_test branch September 20, 2024 06:25
@enjoy-binbin enjoy-binbin added the test-failure An issue indicating a test failure label Sep 26, 2024
madolson pushed a commit to madolson/valkey that referenced this pull request Oct 1, 2024
@enjoy-binbin @madolson
Fix timing issue in the new tot-net-out replica test (valkey-io#1060)
db9e1ad 
Apparently there is a timing issue when using wait_for_ofs_sync:
```
[exception]: Executing test client: can't read "out_before": no such variable.
can't read "out_before": no such variable
```

The reason is that if the connection between the primary
and the replica is not established yet, the master_repl_offset
of the primary and replica in wait_for_ofs_sync is 0, and
the check fails, resulting in no replica client in the
client list below.

In this case, we need to make sure the replica is online
before proceeding.

Signed-off-by: Binbin <[email protected]>
PingXie pushed a commit to PingXie/valkey that referenced this pull request Oct 9, 2024
@enjoy-binbin @PingXie
Fix timing issue in the new tot-net-out replica test (valkey-io#1060)
055aa68 
Apparently there is a timing issue when using wait_for_ofs_sync:
```
[exception]: Executing test client: can't read "out_before": no such variable.
can't read "out_before": no such variable
```

The reason is that if the connection between the primary
and the replica is not established yet, the master_repl_offset
of the primary and replica in wait_for_ofs_sync is 0, and
the check fails, resulting in no replica client in the
client list below.

In this case, we need to make sure the replica is online
before proceeding.

Signed-off-by: Binbin <[email protected]>
naglera pushed a commit to naglera/placeholderkv that referenced this pull request Oct 10, 2024
@enjoy-binbin @naglera
Fix timing issue in the new tot-net-out replica test (valkey-io#1060)
9a60784 
Apparently there is a timing issue when using wait_for_ofs_sync:
```
[exception]: Executing test client: can't read "out_before": no such variable.
can't read "out_before": no such variable
```

The reason is that if the connection between the primary
and the replica is not established yet, the master_repl_offset
of the primary and replica in wait_for_ofs_sync is 0, and
the check fails, resulting in no replica client in the
client list below.

In this case, we need to make sure the replica is online
before proceeding.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: naglera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PingXie PingXie PingXie approved these changes

@zuiderkwast zuiderkwast Awaiting requested review from zuiderkwast

Assignees
No one assigned
Labels
test-failure An issue indicating a test failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enjoy-binbin @PingXie