Fix 1003 Angular 10 Compatibility

[jziggas]

No description provided.

[valorkin]

thanks for helping out

[sguiheux]

Possible to have a release with the fix ? :)
Thanks a lot

[EmaGht]

After a month from the original request of a release with this fix...

I really need this too. Could you please?
Thanks!

[valorkin]

This was released a while ago, as far as remember version 6+
@daniloff200 cc

[EmaGht]

@valorkin There is no version 6+ of ng2 dragula on npm. The last version available (2.1.1) still fails on NG10 with this error:

[valorkin]

My bad, sorry. Thought I was responding in ngx bootstrap repo

[EmaGht]

Sure, @valorkin, no problem.
Just a heads up tho, in the readme file it reads "Official Angular wrapper", but we are almost at NG11 and this library still doesn't support NG10 so it doesn't really sound "Official". When i want to switch my company repository to the new NG version should i trust the fact this library gets updated or am i better of branching it and mantaining it?
Thanks again!

[valorkin]

I can give you a maintenance access if you wish and add to our slack so you could me. Published was automatical on merge to master

[EmaGht]

I'd be happy to help.

Only thing left to understand is why it didn't automatically publish after the merge of this PR

[jziggas]

I think because the build failed due to the demo code needing to be updated.

[EmaGht]

Well, it all makes sense now.

I'm okay with either becoming a maintainer or just waiting for the library to be fixed, what suits you guys best.

[valorkin]

BUILD ERROR
src/components/dragula.module.ts(10,21): error TS2315: Type 'ModuleWithProviders' is not generic

if this will be fixed, and new version could be released

[reda-alaoui]

Hello @valorkin,

I fixed it here => #1023

[matharu007]

@valorkin: can you plz confirm if the fix for the BUILD ERROR is merged and release. I am getting the same error using ng 11