Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Angular 10 upgrade #1023

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Complete Angular 10 upgrade #1023

merged 1 commit into from
Jan 27, 2022

Conversation

reda-alaoui
Copy link
Contributor

This change follows:

It completes the Angular 10 upgrade and fixes the project build.

@reda-alaoui reda-alaoui mentioned this pull request Oct 26, 2020
Merged
@reda-alaoui reda-alaoui force-pushed the angular-10 branch 10 times, most recently from 884b62d to 751886c Compare October 27, 2020 17:06
@reda-alaoui
Copy link
Contributor Author

Build is now green. Waiting for review.

@vamidi
Copy link

vamidi commented Nov 3, 2020

Would be awesome if this get pushed for the latest release.

@255kb 255kb mentioned this pull request Nov 16, 2020
Closed
5 tasks
@pascalklesse
Copy link

It would be nice if it could be published.

@reda-alaoui
Copy link
Contributor Author

Hello?

@chriscarpenter12
Copy link

Can someone merge this fix please?

@reda-alaoui
Copy link
Contributor Author

Ping :)

1 similar comment
@reda-alaoui
Copy link
Contributor Author

Ping :)

@reda-alaoui
Copy link
Contributor Author

Is there something I can do to ease the merge of this fix?

@matharu007
Copy link

Someone plz confirm if the fix is merged and ready to use in ng 11

@Lertis
Copy link

Lertis commented Mar 3, 2021

Someone plz confirm if the fix is merged and ready to use in ng 11

Interested too.

@Qsaws
Copy link

Qsaws commented Mar 4, 2021

Any chance for this to be merged for a new release ?

@Lertis
Copy link

Lertis commented Mar 9, 2021 •
edited
Loading

Waiting for the Merge button to be pressed

@jc0rtes
Copy link

jc0rtes commented Apr 15, 2021

ward

@fhebuterne
Copy link

@jziggas Hi, could you check this pull request please ?

@jziggas
Copy link
Contributor

jziggas commented Apr 20, 2021

@fhebuterne I don't have access to this repo. Nothing I can do.

@furkanfindik
Copy link

Hello, we are waiting for this merge. We are getting this error:
image

@rodizipa
Copy link

pong

@prinju-experion
Copy link

Marko...

@odiazjs
Copy link

odiazjs commented Sep 29, 2021 •
edited
Loading

can this be merged please? @reda-alaoui

@reda-alaoui
Copy link
Contributor Author

@odiazjs , I do not have any permission on this repository ...

@odiazjs
Copy link

odiazjs commented Sep 29, 2021

@reda-alaoui oh well, skipLibCheck it is then...

@valorkin valorkin merged commit 5c8a8f4 into valor-software:master Jan 27, 2022
@vamidi vamidi mentioned this pull request Jan 27, 2022
Closed
@Xaivteev
Copy link

Can this be released on npm?

@djessenb
Copy link

@valorkin Could you maybe release the new version to NPM?

@valorkin
Copy link
Member

@djessenb yes, this week we will be merging, reviewing releasing, new versions

@grg-kvl
Copy link

grg-kvl commented Oct 29, 2022

@valorkin any update on releasing npm version?

@nikhil-kapoor-quo
Copy link

any updates ?

@reda-alaoui reda-alaoui deleted the angular-10 branch June 8, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

@peteichuk peteichuk peteichuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.