Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug report] Jasmine Typing errors #896

Closed
5 tasks done
andyrue opened this issue Aug 29, 2018 · 4 comments
Closed
5 tasks done

[bug report] Jasmine Typing errors #896

andyrue opened this issue Aug 29, 2018 · 4 comments

Comments

@andyrue
Copy link

andyrue commented Aug 29, 2018

REQUIRED: Before filing a bug report

Change each [ ] to [x] when you have done it.

Describe the bug (required)

I'm in the process of updating to Angular 6 and with that ng2-dragula v2.0.2. When I run ng serve I get:

ERROR in node_modules/ng2-dragula/dist/jasmine.d.ts(2,38): error TS1147: Import declarations in a namespace cannot reference a module.
node_modules/ng2-dragula/dist/jasmine.d.ts(2,38): error TS2307: Cannot find module 'testdouble'.
node_modules/ng2-dragula/dist/testdouble-jasmine.d.ts(3,33): error TS2709: Cannot use namespace 'CustomMatcherFactories' as a type.

To Reproduce (required)

Steps to reproduce the behavior:

This may be isolated to me, but the way I reproduce it is to install the latest version of Angular and [email protected] in my project. Then run ng serve

Versions (required)

Please state which versions of the following packages you have installed:

  • @angular/core: 6.1.4
  • ng2-dragula: 2.0.2
@cormacrelf
Copy link
Contributor

Typescript version please

@andyrue
Copy link
Author

andyrue commented Aug 30, 2018

typescript: 2.9.2

cormacrelf added a commit that referenced this issue Aug 31, 2018
@andyrue
Copy link
Author

andyrue commented Aug 31, 2018

I apologize, this turned out to be my fault. After installing the latest update 2.0.4 and still having the problem, I continued digging and realized I was including "../node_modules/ng2-dragula/**/*.ts", in my tsconfig.app.json file. I had only checked my tsconfig.json file for stray entries. I was including the folder before because I was using a forked version and installing from git. Sorry for the trouble.

@cormacrelf
Copy link
Contributor

Well, those .d.ts weren't meant to be there, so no harm done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants