Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #912 #914

Closed
wants to merge 1 commit into from
Closed

Conversation

vesrah
Copy link

@vesrah vesrah commented Oct 29, 2018

Fix

Class 'MockDrake' incorrectly implements interface 'DrakeWithModels'. Types of property 'on' are
            incompatible. Type '(event: string, callback: Function) => void' is not assignable to type '(events: string,
            callback: Function) => Drake'. Type 'void' is not assignable to type 'Drake'.

Relevant issues

#912
#913

Before submitting

If your pull request includes changes to the library code:

  • Add tests (in modules/ng2-dragula/src/spec/...) for any code you have changed
  • Make sure the test suite passes
  • Make sure the demo app isn't broken

@vesrah vesrah closed this Oct 29, 2018
@vesrah vesrah deleted the bugfix/fix-build branch October 29, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant