feat: add restartDelay option #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Declared as optional, consistent with other types in UpdateOption - Added comments for bettwr clarity
- Applied `??` operator to set default(=300ms) for `undefined` or `null` - Ensures restartDelay applies the user-defined value when provided - Enforces type safety: only `number` values are allowed, preventing invalid types
src/index.tsx
Outdated
| @@ -154,7 +154,7 @@ async function downloadBundleUri( | |||
| if (option?.restartAfterInstall) { | |||
| setTimeout(() => { | |||
| resetApp(); | |||
| }, 300); | |||
| }, option?.restartDelay ?? 300); | |||
There was a problem hiding this comment.
I think it better when use || instead of ??
There was a problem hiding this comment.
I compared the ?? and || operators, and it seems that || is more appropriate as it covers all falsy values. I'll apply the change right away! Thanks! 😊
| * Delay in milliseconds before restarting the app after installing the update. | ||
| * Default: 300ms. | ||
| */ | ||
| restartDelay?: number; |
There was a problem hiding this comment.
It great if you can help me update at readme also
There was a problem hiding this comment.
Oh! I'll add it right away!
BangDori
changed the title
|
all good, thank for your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
restartAfterInstalloption in OTA updates had a hardcoded timeout of300msbefore restarting the app.This made it feel like the app restarted too quickly, preventing a smooth transition.
How
To improve flexibility,
restartDelayis set by the developer.Related Issue
[AS-IS]
[TO-BE]
left - default (300ms) / right - user-defined (3000ms)