-
Notifications
You must be signed in to change notification settings - Fork 280
Doc: Explain what 'Prevent migration' does #8222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users weren't sure what a 'block migration' was. This commit explains in the XO documentatiojn that 'block migration' isn't meant as a noun phrase but rather an instruction, as in 'prevent migrations'. Hopefully this will prevent any confusion till we update the actual button label Signed-off-by: Thomas Moraine <[email protected]>
IHMO we need to do both:
Let's wait for the 2. being done and then we'll merge this accordingly. |
MathieuRA
requested changes
Apr 9, 2025
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
'Prevent' is more appropriate than 'Disable' in this case
pdonias
pushed a commit
that referenced
this pull request
Apr 10, 2025
MathieuRA
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users weren't sure what a 'block migration' was. This PR updates the Xen Orchestra documentation to explain that 'Block migration' is an imperative phrase and that enabling this option will prevent the VM from migrating to another host.
Hopefully this will prevent any further confusion till we update the actual button label.
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: