Skip to content

fix(xo-server/createVm): fix DEVICE_ALREADY_EXISTS #8473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Apr 1, 2025

Description

Introduced by 04dd9e9

See mm
zammad#36543

If no userdevice is specified, VBD_create will determine himself which one to use.
So Promise.all will leads to unwanted behaviour. (Same userdevice for multiple VBD).
This PR ensures that we always provide a userdevice to VBD_create to ensure there are no more duplicate userdevices

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA self-assigned this Apr 1, 2025
@MathieuRA MathieuRA changed the title fix(xo-server): fix VBD create race condition fix(xo-server/createVm): fix DEVICE_ALREADY_EXISTS Apr 1, 2025
@MathieuRA MathieuRA marked this pull request as ready for review April 1, 2025 15:55
@MathieuRA MathieuRA requested a review from b-Nollet April 1, 2025 15:55
Copy link
Contributor

@b-Nollet b-Nollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't access the mm link in the description. Maybe it's just a matter of permissions, but make sure the link is working properly.

@b-Nollet b-Nollet requested a review from fbeauchamp April 2, 2025 07:27
@MathieuRA
Copy link
Member Author

I can't access the mm link in the description. Maybe it's just a matter of permissions, but make sure the link is working properly.

The link is working properly. It's just a private channel with a partner

@MathieuRA MathieuRA requested a review from b-Nollet April 9, 2025 12:46
@b-Nollet b-Nollet requested a review from fbeauchamp April 10, 2025 07:51
@MathieuRA MathieuRA removed the request for review from fbeauchamp April 10, 2025 08:24
@MathieuRA MathieuRA requested a review from b-Nollet April 10, 2025 08:38
@b-Nollet b-Nollet requested a review from fbeauchamp April 10, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants