-
Notifications
You must be signed in to change notification settings - Fork 280
fix(xo-server/createVm): fix DEVICE_ALREADY_EXISTS #8473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't access the mm link in the description. Maybe it's just a matter of permissions, but make sure the link is working properly.
The link is working properly. It's just a private channel with a partner |
Description
Introduced by 04dd9e9
See mm
zammad#36543
If no userdevice is specified,
VBD_create
will determine himself which one to use.So Promise.all will leads to unwanted behaviour. (Same userdevice for multiple VBD).
This PR ensures that we always provide a
userdevice
toVBD_create
to ensure there are no more duplicateuserdevices
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: