Skip to content

feat(xo-lite): add affinity host field in vm creation, added pbd store, type and translation #8486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

J0ris-K
Copy link
Contributor

@J0ris-K J0ris-K commented Apr 4, 2025

Description

add affinity host field in vm creation, added pbd store, type and translation

ScreenShoots

image
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@J0ris-K J0ris-K added the XO Lite label Apr 4, 2025
@J0ris-K J0ris-K requested a review from MathieuRA April 4, 2025 15:55
@J0ris-K J0ris-K self-assigned this Apr 4, 2025
@J0ris-K J0ris-K force-pushed the lite/vm-creation-add-affinity-host branch from eff3b98 to 9f02415 Compare April 4, 2025 15:58
@J0ris-K J0ris-K requested review from S3bastianCZ and removed request for MathieuRA April 7, 2025 06:53
@S3bastianCZ S3bastianCZ requested a review from OlivierFL April 8, 2025 08:38
@J0ris-K J0ris-K force-pushed the lite/vm-creation-add-affinity-host branch from 4a9e01e to 7e913a0 Compare April 8, 2025 12:12
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with the idea of ​​filtering possible affinity hosts based on the VM's VDIs and filtering the VDI's SRs based on those the affinity host, does Clémence approve of this workflow?
If so, we'll need to do the same for XO6. (We need to keep the behavior as similar as possible between XO6 and XOLite.)

@J0ris-K J0ris-K requested review from S3bastianCZ and OlivierFL April 9, 2025 06:25
@J0ris-K J0ris-K changed the title feat(xo-lite): added affinity host field in vm creation, added pbd store, type and translation feat(xo-lite): add affinity host field in vm creation, added pbd store, type and translation Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants