-
Notifications
You must be signed in to change notification settings - Fork 280
feat(@xen-orchestra/rest-api): expose get group and get groups #8496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it normal that you didn't add groups: {},
to swaggerEndpoints
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the type XoGroup
.
provider
and providerGroupId
are missing
|
||
/** | ||
* @example fields "name,id" | ||
* @example filter "users:722d17b9-699b-49d2-8193-be1ac573d3de" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use an explicit filter that will not work outside of your XOA
Co-authored-by: Mathieu <[email protected]>
* @example fields "name,id" | ||
* @example filter "users:/^<user-id>/" | ||
* @example limit 42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #8490 (comment)
|
||
/** | ||
* @example fields "name,id" | ||
* @example filter "users:/^<user-id>/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filter is invalid; it will not work without editing the input.
If you want to filter on user properties, filter on the length of that property, for example
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: