Skip to content

Commit 1393ba9

Browse files
author
Release Manager
committed
sagemathgh-38715: Define feature `sage.libs.giac` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The tag `# needs sage.libs.giac` has already appeared in a few places, but the feature was not defined. - This complements sagemath#38672 @orlitzky - Cherry-picked from from sagemath#35095 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38715 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
2 parents bd2a006 + be15aba commit 1393ba9

File tree

1 file changed

+27
-0
lines changed

1 file changed

+27
-0
lines changed

src/sage/features/sagemath.py

+27
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,32 @@ def __init__(self):
537537
spkg='sagemath_ntl', type='standard')
538538

539539

540+
class sage__libs__giac(JoinFeature):
541+
r"""
542+
A :class:`sage.features.Feature` describing the presence of :mod:`sage.libs.giac`.
543+
544+
In addition to the modularization purposes that this tag serves,
545+
it also provides attribution to the upstream project.
546+
547+
TESTS::
548+
549+
sage: from sage.features.sagemath import sage__libs__giac
550+
sage: sage__libs__giac().is_present() # needs sage.libs.giac
551+
FeatureTestResult('sage.libs.giac', True)
552+
"""
553+
def __init__(self):
554+
r"""
555+
TESTS::
556+
557+
sage: from sage.features.sagemath import sage__libs__giac
558+
sage: isinstance(sage__libs__giac(), sage__libs__giac)
559+
True
560+
"""
561+
JoinFeature.__init__(self, 'sage.libs.giac',
562+
[PythonModule('sage.libs.giac.giac')],
563+
spkg='sagemath_giac', type='standard')
564+
565+
540566
class sage__libs__homfly(JoinFeature):
541567
r"""
542568
A :class:`sage.features.Feature` describing the presence of :mod:`sage.libs.homfly`.
@@ -1155,6 +1181,7 @@ def all_features():
11551181
sage__libs__ecl(),
11561182
sage__libs__flint(),
11571183
sage__libs__gap(),
1184+
sage__libs__giac(),
11581185
sage__libs__homfly(),
11591186
sage__libs__linbox(),
11601187
sage__libs__m4ri(),

0 commit comments

Comments
 (0)