Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyncio testing #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Asyncio testing #467

wants to merge 1 commit into from

Conversation

tony
Copy link
Member

@tony tony commented Jun 19, 2024

Changes

Dev deps: Add pytest-asyncio

See also: https://github.com/pytest-dev/pytest-asyncio

Summary by Sourcery

Tests:

  • Add pytest-asyncio for testing asynchronous code.

@tony
Copy link
Member Author

tony commented Jan 11, 2025

@sourcery-ai review

Copy link

sourcery-ai bot commented Jan 11, 2025

Reviewer's Guide by Sourcery

This pull request adds pytest-asyncio to the development dependencies.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added pytest-asyncio dependency
  • Added pytest-asyncio to the pyproject.toml file.
  • Updated poetry.lock file to reflect the new dependency
pyproject.toml
poetry.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tony - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tony tony force-pushed the asyncio-experiment branch from 55536e9 to 5322218 Compare January 11, 2025 20:56
@tony tony force-pushed the asyncio-experiment branch 2 times, most recently from a7e1cf1 to 76dbac5 Compare February 22, 2025 23:23
@tony tony force-pushed the asyncio-experiment branch from 76dbac5 to a133af8 Compare February 22, 2025 23:46
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.09%. Comparing base (aeb91cd) to head (a133af8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   54.09%   54.09%           
=======================================
  Files          40       40           
  Lines        3627     3627           
  Branches      793      793           
=======================================
  Hits         1962     1962           
  Misses       1314     1314           
  Partials      351      351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant