-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Typo fixes #484
base: master
Are you sure you want to change the base?
Docs: Typo fixes #484
Conversation
Reviewer's Guide by SourceryThis pull request focuses on fixing typos and improving clarity across the documentation, including updates to installation instructions, explanations of versioning, and code examples. It also includes type hints to the Updated class diagram for the my_git_repo fixtureclassDiagram
class CreateRepoPytestFixtureFn {
}
class Dict~str, Any~ {
}
class Path {
}
my_git_repo -- CreateRepoPytestFixtureFn : create_git_remote_repo
my_git_repo -- Path : gitconfig
my_git_repo -- Dict~str, Any~ : git_commit_envvars
my_git_repo -- Path : return
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes look good, but it would be helpful to add a brief explanation of why
python -m pip
is preferred overpip
. - In
pytest-plugin.md
, the code block definingmy_git_repo
could benefit from a docstring explaining its purpose.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
d25926b
to
b12e1e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 54.09% 54.09%
=======================================
Files 40 40
Lines 3627 3627
Branches 793 793
=======================================
Hits 1962 1962
Misses 1314 1314
Partials 351 351 ☔ View full report in Codecov by Sentry. |
… and add Python syntax highlighting
…th main installation format
b12e1e2
to
ef267cc
Compare
Summary by Sourcery
Fix typos and improve clarity in various documentation sections.
Documentation: