Fix variadic parameter handling in .EXPECT().Run()
#1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue was reported where the `.Run()` method of testify mocks was not handling variadic parameters correctly when `unroll-variadic: False`. It was attempting to grab the variadic parameters one by one by iterating through the argument list, when instead it should have just grabbed the last argument and type asserted it as a slice of the variadic type. Fixes vektra#1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was reported where the
.Run()method of testify mocks was not handling variadic parameters correctly whenunroll-variadic: False. It was attempting to grab the variadic parameters one by one by iterating through the argument list, when instead it should have just grabbed the last argument and type asserted it as a slice of the variadic type.Fixes #1024