Skip to content

Commit f4a887e

Browse files
authored
TS Strict ButtonGroup (adobe#3185)
* TS Strict ButtonGroup
1 parent dcdd098 commit f4a887e

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

packages/@react-aria/utils/src/useResizeObserver.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function hasResizeObserver() {
55
}
66

77
type useResizeObserverOptionsType<T> = {
8-
ref: RefObject<T>,
8+
ref: RefObject<T | undefined>,
99
onResize: () => void
1010
}
1111

packages/@react-spectrum/buttongroup/src/ButtonGroup.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ function ButtonGroup(props: SpectrumButtonGroupProps, ref: DOMRef<HTMLDivElement
7575
// 2. External changes: buttongroup won't change size due to any parents changing size, so listen to its container for size changes to figure out if we should remeasure
7676
let parent = useRef<HTMLElement>();
7777
useLayoutEffect(() => {
78-
parent.current = domRef.current.parentElement;
78+
if (domRef.current) {
79+
parent.current = domRef.current.parentElement as HTMLElement;
80+
}
7981
}, [domRef.current]);
8082
useResizeObserver({ref: parent, onResize: checkForOverflow});
8183

tsconfig.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
{
3434
"name": "typescript-strict-plugin",
3535
"paths": [
36-
"./packages/@react-spectrum/button/s",
36+
"./packages/@react-spectrum/button",
3737
]
3838
}
3939
]

0 commit comments

Comments
 (0)