Verify that webgl2 is supported before using it #3435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabou
suggested changes
Jan 23, 2019
lib/components/term.js
Outdated
| isSupported = gl instanceof window.WebGL2RenderingContext; | ||
| if (!isSupported) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn(`WebGL2 is not supported on your machine. Falling back to canvas-based rendering.`); |
There was a problem hiding this comment.
I would move this warning in getTermOptions where fallback occurs. This is juste a test here.
We can warn if webGL is disabled due to a non-opaque backgroundColor too.
There was a problem hiding this comment.
Sorry, linting issues on push. One sec
There was a problem hiding this comment.
Ok, now it's done. I need to set up eslint integration in vim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hardware/drivers seem to not support WebGL2 (now our default renderer) which completely breaks hyper.
Check that webgl2 is supported before using.
This seems to add ~10ms to my startup time, which I think it's acceptable. The alternative being catching an exception in
Terminal.openand then falling back to canvas.fixes #3433