feat(bun): bun prune support #10175
Merged
feat(bun): bun prune support #10175
+413
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
the
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@camero2734 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
camero2734
changed the title
chris-olszewski
pushed a commit
that referenced
this pull request
Mar 31, 2025
### Description Resolves #9058 and #7456 (again) When I tested my previous PR (#10175) on another repo, I discovered an issue with a missing dep in the pruned lockfile To reproduce this in the `with-yarn` example repo: `cd apps/web && bun install dd-trace` and `cd apps/docs && bun install @opentelemtry/api` Then run prune for `web` and try `bun install --frozen-lockfile` and you'll get this: ``` error: Failed to resolve peer dependency '@opentelemetry/api' for package '@opentelemetry/core' at bun.lock:1:16974 InvalidPackageInfo: failed to parse lockfile: 'bun.lock' ``` ### Issue 1 -- Deserialization casing The underlying error is rather straightforward -- it was deserializing most dependencies (`peerDependencies`, `devDependencies`, `optionalDependencies`) to `other` 😄  This is because it just needed `#[serde(rename_all = "camelCase")]` since the rust names are snake case. This is why `dependencies` happened to work -- it's the same in snake and camel case. By virtue of being in `other`, all non-`dependencies` packages were effectively ignored during the pruning process, and don't always end up in the resulting lockfile. ### Issue 2 -- optionalPeers After fixing that, I also stumbled upon another issue: ``` WARNING Unable to calculate transitive closures: No lockfile entry found for 'next/@playwright/test' ``` This is because we weren't accounting for the `optionalPeers` property. `next` doesn't actually require you have `@playwright/test`, it's an optional peer. I fixed this as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9058 and #7456
Building on #9783 to add
prunesupport for bun. This is a simple implementation that allow turbo to properly prune abun.lockfileBasically, it just creates a new
BunLockfileDatawith the filtered dependencies/workspaces and serializes it tobun.lockviaserde_json. This is made simple since the internal layout matches the bun.lock format, so the only special serialization case I had to do wasPackageEntry. This also required updating the deserialization, since it skipped parsing some parts that we need to write back out.Testing Instructions
bun install --save-text-lockfile(we need the new.lockversion and not.lockb)out/bun.lock. It's currently outputted in an unformatted json, so I format it.elysia) and root workspace (commitizen) dependencies, but not e.g.@turbobun/websitedependencies (likenext)cd ./out/json && bun install-> Bun install can read the lockfile and works!bun patchand test that the patches are propagated correctlyScreenshots