Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the select pageable #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

olafgeibig
Copy link

Sorry, I don't know scala so I coded like java. I made just a small change to optionally make the select statement able to page with LIMIT and OFFSET. This was trivial as MySQL and PostgreSQL share the same syntax.

@Narigo
Copy link
Member

Narigo commented May 23, 2014

This would be perfect if you could add some tests :)
And maybe you need to sign the eclipse CLA, since this is an "official" vert-x module. Not sure how I could see that... 😕

@Narigo
Copy link
Member

Narigo commented Dec 24, 2014

@olafgeibig while porting the module as a service to Vert.x 3, I've seen that MySQL and PostgreSQL are not completely the same in that regard. In MySQL you always have to provide a LIMIT clause, but in PostgreSQL you don't. So my workaround there was this: https://github.com/vert-x3/vertx-mysql-postgresql-service/blob/initial-work/src/main/scala/io/vertx/ext/asyncsql/mysql/impl/MysqlOverrides.scala#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants