-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Polish] Remove blocks from default menu #58
Comments
Hey @stephaniefois, so I frustratingly had a bug in my code and just figured out the solution, so I've about to create a PR for this ticket, however, I noticed that when we disable some of the core blocks that we're using in our components or patterns, they do not populate when creating a new component. Existing instances of components using the blocks that have been removed still work fine (for example, the Media Text block inside the Text & Image block). So it appears we will need to keep any blocks in the inserter that we plan on using anywhere on the site. There may be an alternative JS solution using some of the block hooks/filters, but I didn't want to spend too much time on this, and may be something we can circle back to. The blocks in the list that I couldn't remove are:
Some other considerations might be:
Let me know your thoughts! |
Let's leave all the blocks you touched on in then; your reasoning makes sense to me! |
There are many core blocks that likely will seldom, if ever, get used on projects that Viget designs. There are also blocks that, while useful in capable and responsible hands, might be the type of blocks that can go awry if we have not taken the time to define style and usage principles; for those reasons, I am suggesting those types of blocks be removed from our stater site theme.
In my opinion, these are all the core blocks I think should be hidden from the user:
The text was updated successfully, but these errors were encountered: