Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#102] Removing parent wp-block class from button css #109

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

nathan-schmidt-viget
Copy link
Contributor

@nathan-schmidt-viget nathan-schmidt-viget commented Jun 14, 2024

Summary

Bug I found when styling the buttons for IAFFF. The buttons styles correctly if they are in a pattern/component but not if they are just a button in the WP core Button group. Removing the parent classes fixes the problem.

Issues

Testing Instructions

  1. Add the button group to a page and make sure they are styled in the WP editor and the frontend.
  2. Make sure the buttons are styled in our blocks.

Screenshots

With parents classes on buttons css

Screenshot 2024-06-14 at 2 40 40 PM

With OUT parents classes on buttons css

Screenshot 2024-06-14 at 2 40 12 PM

@nathan-schmidt-viget nathan-schmidt-viget merged commit 3a7d918 into main Jun 17, 2024
@nathan-schmidt-viget nathan-schmidt-viget deleted the ns/102-parent-class branch June 17, 2024 15:00
@bd-viget
Copy link
Contributor

I'm not even sure having the wp-block and/or acf-block is helpful, it was something that got pulled over from IAFF, so if we don't think they're useful identifiers, we can remove those from the ACF blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants