-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#124] Adding btn icon function #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the icons we had into the icons
folder. Does not seem like that messes up anything with the block. But that made me think, do we need these icons if we don't use them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I had them in there just because they were the source icons for some of the custom blocks, but since they're embedded into the block.json
, then they're probably not necessary here. Also, we should probably create a task to build a complete set of icons for all of our custom blocks so they all match and look consistent. I tried once, but took forever and couldn't find ones that made sense for some of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea with the custom icons for our blocks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I had them in there just because they were the source icons for some of the custom blocks, but since they're embedded into the block.json
, then they're probably not necessary here. Also, we should probably create a task to build a complete set of icons for all of our custom blocks so they all match and look consistent. I tried once, but took forever and couldn't find ones that made sense for some of them.
Summary
This adds in the function to add custom icons to the button block.
Issues
Testing Instructions
wp-content/themes/wp-starter/inc/icons.php
and add a custom icon.Screenshots