Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#124] Adding btn icon function #131

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

nathan-schmidt-viget
Copy link
Contributor

Summary

This adds in the function to add custom icons to the button block.

Issues

Testing Instructions

  1. Go into the file wp-content/themes/wp-starter/inc/icons.php and add a custom icon.
  2. Make sure that icons pull into the button icon set.

Screenshots

Screenshot 2024-07-23 at 3 56 56 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the icons we had into the icons folder. Does not seem like that messes up anything with the block. But that made me think, do we need these icons if we don't use them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had them in there just because they were the source icons for some of the custom blocks, but since they're embedded into the block.json, then they're probably not necessary here. Also, we should probably create a task to build a complete set of icons for all of our custom blocks so they all match and look consistent. I tried once, but took forever and couldn't find ones that made sense for some of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with the custom icons for our blocks!

Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had them in there just because they were the source icons for some of the custom blocks, but since they're embedded into the block.json, then they're probably not necessary here. Also, we should probably create a task to build a complete set of icons for all of our custom blocks so they all match and look consistent. I tried once, but took forever and couldn't find ones that made sense for some of them.

@nathan-schmidt-viget nathan-schmidt-viget merged commit acc3639 into main Jul 26, 2024
@nathan-schmidt-viget nathan-schmidt-viget deleted the ns/124-button-icons branch July 26, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants