Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#122] 404 page #132

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[#122] 404 page #132

merged 1 commit into from
Jul 29, 2024

Conversation

nathan-schmidt-viget
Copy link
Contributor

Summary

Adds the 404 template page to the starter.

Issues

Testing Instructions

  1. Go to a nonpage like /testing and make sure the 404 content shows up.

Screenshots

NA

@nathan-schmidt-viget nathan-schmidt-viget marked this pull request as ready for review July 25, 2024 19:25
@nathan-schmidt-viget nathan-schmidt-viget self-assigned this Jul 25, 2024
Comment on lines +5 to +10
<!-- wp:heading {"level":1} -->
<h1 class="wp-block-heading" id="page-not-found">Page Not Found</h1>
<!-- /wp:heading -->
<!-- wp:paragraph -->
<p>The page you are looking for does not exist, or it has been moved.</p>
<!-- /wp:paragraph -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried at first to put this in a pattern, but then ran into errors with it not pulled from that pattern. So, I kept it simple.
It will mostly be updated per site

Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@nathan-schmidt-viget nathan-schmidt-viget merged commit e4f89b3 into main Jul 29, 2024
@nathan-schmidt-viget nathan-schmidt-viget deleted the ns/122-404-page branch July 29, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants