-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#130] Block clean up and refactor #138
Conversation
12b7b01
to
14c240e
Compare
dbe5fee
to
cf9008b
Compare
This adjusts the width for all blocks so they can have a full width background color but the content is constrained.
2ba5d99
to
b1b8134
Compare
b1b8134
to
a275e30
Compare
@bd-viget Refactored on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just a few notes, but overall this is great and a ton of work! One recurring comment was just the hard-coding of alignwide
and not the ability to configure that using the block editor settings.
Let's push out a release after this is merged! |
d598e73
to
7f59f23
Compare
@apply mx-auto; | ||
} | ||
|
||
.entry-content > .alignfull { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to add the >
otherwise we could not nest blocks inside of other blocks.
@apply mt-0; | ||
} | ||
|
||
.entry-content > *:not(.alignfull), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to target entry-content
so just the main content items and not the header/footer.
7f59f23
to
6d7c797
Compare
@bd-viget Going to merge this! We may have a few small things to fix but we can do that in new PRs. |
@nathan-schmidt-viget Sounds good! |
Summary
template
array../**/*.css
Issues
Testing Instructions
ddev npm run plop block
and add a new block.Screenshots
New file structure.
Blocks now default to full-width bg color.