Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#141] Fixing css/js bugs with preview and console log #142

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

nathan-schmidt-viget
Copy link
Contributor

Summary

Fixes the css missing in preview mode.
Removes the duplicate Vite call.
Adds our custom css/js at the vary bottom of the head tag which fixes the importmap error

Issues

Testing Instructions

  1. Make sure there is no importmap error in the console.
  2. If you view a page in Preview the styles look the same.

Screenshots

NA

Copy link
Contributor

@bd-viget bd-viget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@bd-viget bd-viget merged commit 94eb448 into main Sep 10, 2024
@bd-viget bd-viget deleted the ns/141-css-js-bugs branch September 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants